Skip to content
This repository has been archived by the owner. It is now read-only.

Use frontend_toolkit analytics #173

Merged
merged 2 commits into from Mar 14, 2015
Merged

Use frontend_toolkit analytics #173

merged 2 commits into from Mar 14, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 13, 2015

As part of the switch over to using Universal analytics we need to track to both Classic and Universal and check that what is tracked is comparable. For this govuk_frontend_toolkit has some analytics helpers.

  • Remove inline analytics code
  • Remove proposition custom variable
  • Use frontend_toolkit to track pageviews, events and custom dimensions to both classic and universal
  • Move section and need ids into meta tags for analytics JS to read (matching slimmer's approach)
  • Introduce print intent and js error events
fofr added 2 commits Mar 12, 2015
Track to both classic and universal trackers simultaneously
Tests were failing because @DaTa wasn’t always present. If
there is no data or details, then there are no need_ids.

Remove the now unused proposition method.
matthewford added a commit that referenced this pull request Mar 14, 2015
Use frontend_toolkit analytics
@matthewford matthewford merged commit e219365 into master Mar 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@matthewford matthewford deleted the analytics branch Mar 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.