Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show organisations with sites #108

Merged
merged 7 commits into from Dec 9, 2013
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 6, 2013

  • We’ve got hundreds of organisations now, if they don’t have any sites
    being transitioned they shouldn’t be shown
  • When the list grows long again we’ll need a better solution, probably
    a filter
* We’ve got hundreds of organisations now, if they don’t have any sites
being transitioned they shouldn’t be shown
* When the list grows long again we’ll need a better solution, probably
a filter
@rgarner

This comment has been minimized.

Copy link
Contributor

@rgarner rgarner commented on f633fbd Dec 6, 2013

There are a couple of things this needs to do:

  • Do the filtering DB-side (as opposed to Enumerable#select)
  • Have the feature assert that orgs without sites don't show
@ghost ghost assigned rgarner Dec 6, 2013
<small>Transitioning <%= @site_count %> government sites, across <%= @organisations.count %> organisations, to GOV.UK.</small>
<small>
Transitioning <%= @site_count %> government sites,
across <%= @organisations.length %> organisations, to GOV.UK.

This comment has been minimized.

@rgarner

rgarner Dec 6, 2013
Contributor

@organisations.count becomes @organisations.length, for those struggling to see the wood for the whitespace.

jamiecobbett added a commit that referenced this pull request Dec 9, 2013
@jamiecobbett jamiecobbett merged commit 3b939b5 into master Dec 9, 2013
@jamiecobbett jamiecobbett deleted the hide-orgs-without-sites branch Dec 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.