Opening this to start more visible discussion, since it's a big one.
The only acceptance criterion from the story which this doesn't address at all is client-side validation of the new URL input, but we think that is done adequately server-side for now.
Specify js interaction using class name so that only clicking the header checkbox toggles table rows.
* The browser maintains the state of checkboxes when moving back/forward, our page needs to respond by applying the selected row class * The header state should also remain in sync * Refactor so that shift clicking and normal clicking use the same code paths * Toggling a checkbox with shift click when no previous toggles have been changed should work as normal
* The toggle on the checkbox in the header wasn’t specific enough and was affecting the default state of the radio buttons * Update module and tests to use js prefixed class names rather than elements * Tweak alignment of radio buttons by removing padding and adding margins
This still had the official description for the codes, rather than our more user-friendly ones.
* Refer to selecting mappings, not clicking checkboxes * Refer to editing a selection, not clicking a specific button * Refer to a form containing a selection, not a list of URLs * Refer to saving changes, rather than clicking a save button (Mostly implementing @rgarner’s suggestions)
* Helps edit/update_multiple read ok * May violate SRP slightly, but probably less than we were doing