Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 3 #126

Merged
merged 18 commits into from Dec 30, 2013
Merged

Upgrade to Bootstrap 3 #126

merged 18 commits into from Dec 30, 2013

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 23, 2013

  • Update markup, styles and javascript to work with bootstrap 3
  • Main changes: Form markup patterns, grid patterns and navbar layout
  • See http://getbootstrap.com/getting-started/#migration for changes
  • Maintain bootstrap 2 button styles
  • Gives us access to all the new bootstrap 3 features/patterns
Paul Hayes added 18 commits Dec 23, 2013
* Remove bootstrap responsive include, that’s now the default
* Switch from Bootstrap 2 camel cased variables to hyphen separated
Bootstrap 3 ones
* Update our own variables to match too
* Switch from brand to navbar-brand class
* Default buttons now need a btn-default class
* btn-mini is now btn-xs
* Also upgrades all bootstrap js to the latest version
* Mostly adding new wrappers
* Visibility of modal is now managed using the aria attributes
* Move form onto one of the internal wrappers to maintain form aria role
* Use line height base and default font size
* Use in place of $line-height-base which is just a ratio
* Use form-group, input-group and input-group-addon class names
* Extra wrapping is needed for constraining form elements to a width,
now that they behave like table cells
* This is the standard bootstrap grid way, but there’s no reason not to
improve on this later
* Ditch the custom divider in favour of bootstrap 3’s pseudo content
* For consistency with other apps, and for better affordances, use the
original button styles with gradients, rather than the flat versions
* Avoid the blue active state on bootstrap 3’s default pagination styles
* Remove breadcrumbs section as they’re no longer custom
* Update grid examples
* Link to the correct bootstrap docs and code
* Rearrange order of wrappers, placing label in grid cell too and
removing form-group wrapper
* Convert filter from input to button for correct height, it seems
bootstrap 3 doesn’t like input type submit much,
http://stackoverflow.com/questions/18542343/is-there-a-way-a-aligning-my
-input-group-on-firefox-using-bootstrap-3
* Buttons have the correct height in Firefox when using bootstrap 3
* The tabs were too close to the top of the new form after the default
vertical spacing on forms was changed
* Gutter widths are bigger now, and a spacing of 15px is too large
between buttons, reduce to 10px again.
* Remove spurious extra spacing
* Demarcate footer region of modal again
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Dec 30, 2013

Good work. The app also looks better as a result :)

jamiecobbett added a commit that referenced this pull request Dec 30, 2013
@jamiecobbett jamiecobbett merged commit 376d07d into master Dec 30, 2013
@jamiecobbett jamiecobbett deleted the bootstrap-3 branch Dec 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.