Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that entered hosts are part of the current site #161

Merged
merged 2 commits into from Jan 29, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 27, 2014

  • Add a raw_hosts method to bulk_adder to pull out an array of unique hostnames used
  • Check that each of these is a correct site hostname

Caveat: This may be overly strict, eg with and without www at the start of a hostname.

Paul Hayes added 2 commits Jan 24, 2014
* Add a raw_hosts method to bulk_adder to pull out an array of unique
hostnames used
* Check that each of these is a valid site hostname, otherwise return
an error
* Ignore paths

Caveat: This may be overly strict, eg with and without www. at the
start of the hostname.
* When URI parsing fails on what looks like a full URI then
site_has_hosts? should return false
* In tests distinguish between invalid and incorrect
jamiecobbett added a commit that referenced this pull request Jan 29, 2014
Check that entered hosts are part of the current site
@jamiecobbett jamiecobbett merged commit 8a745ff into master Jan 29, 2014
@jamiecobbett jamiecobbett deleted the check-hostname-on-add branch Jan 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.