Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the side by side browser on site dashboards #174

Merged
merged 1 commit into from Feb 10, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 6, 2014

  • Link to the side by side browser for the given site
  • Caveats: This isn’t a smart link and will show for sites without an AKA domain, at the moment neither side by side browser or Transition handles this gracefully.
* Link to the side by side browser for the given site
* Caveats: This isn’t a smart link and will show for sites without an
AKA domain, at the moment neither side by side browser or Transition
handles this gracefully.
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Feb 6, 2014

I'm a bit reluctant to merge this right now because the side-by-side browser at the moment uses the hardcoded whitelist included in the app, which only includes 2 hosts. I'd prefer to see that list regularly updated, but at a minimum replacing it with the full list we currently have. Let's talk tomorrow.

jamiecobbett added a commit that referenced this pull request Feb 10, 2014
Add a link to the side by side browser on site dashboards
@jamiecobbett jamiecobbett merged commit e5f5963 into master Feb 10, 2014
@jamiecobbett jamiecobbett deleted the side-by-side-link branch Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.