Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asset pipeline for access to bootstrap SASS #176

Merged
merged 6 commits into from Feb 10, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 7, 2014

  • Get access to bootstrap styles for extensions, variables and mixins
  • Remove some old bootstrap fixes
  • Update style guide docs to include link to mixins
  • Clean up some legacy styles and variable names
Paul Hayes added 6 commits Feb 7, 2014
* Instead of automatically including all, switch to being specific
about what’s being included and in what order
* This gives all subsequent CSS imports access to bootstrap SASS
variables and mixins while opening the classes up to extension.
* Warning class on striped table rows has been fixed in bootstrap 3.1
* Old error styles seem to have crept back in after an earlier refactor
* The error explanation styles are superseded by bootstrap alert and
alert-danger classes
* Bootstrap has a variable that does this calculation already, with an
additional floor() to round pixel values.
* See http://getbootstrap.com/customize/#typography
* Include a link to mixins, they’re otherwise hard to find (ie not on
bootstrap docs pages)
jamiecobbett added a commit that referenced this pull request Feb 10, 2014
Update asset pipeline for access to bootstrap SASS
@jamiecobbett jamiecobbett merged commit 0e93477 into master Feb 10, 2014
@jamiecobbett jamiecobbett deleted the a-better-css-pipeline branch Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants