Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag filtering #181

Merged
merged 10 commits into from Feb 13, 2014
Merged

Tag filtering #181

merged 10 commits into from Feb 13, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 13, 2014

  • Click tags to show a filtered list of mappings
  • Click multiple tags to show mappings tagged with all those tags
  • Show which tags are filtering mappings in the header
  • Show a tag summary on the site dashboard page that links to tag filtered views
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Feb 13, 2014

This needs a rebase

@@ -43,6 +43,10 @@ def index
else
@mappings.filtered_by_path(@path_contains)
end

if params[:tagged] && params[:tagged].size > 0

This comment has been minimized.

@jamiecobbett

jamiecobbett Feb 13, 2014
Contributor

This would be simpler as if params[:tagged].present?

This comment has been minimized.

@fofr

fofr Feb 13, 2014
Author Contributor

Updated.

@@ -1,6 +1,10 @@
<% content_for(:page_title, "#{@site.default_host.hostname} Mappings") %>

<% breadcrumb(:mappings, @site) %>
<% if filtered_by_tags? || @path_contains.present? %>
<% breadcrumb(:filtered_mappings, @site) %>

This comment has been minimized.

@jamiecobbett

jamiecobbett Feb 13, 2014
Contributor

Should we change the page title and the h1 to match the breadcrumb?

This comment has been minimized.

@fofr

fofr Feb 13, 2014
Author Contributor

Yes, we should. I've updated the title and page title.

Paul Hayes added 10 commits Feb 10, 2014
* Clicking a tag shows all mappings tagged with that tag
* Clicking another tag shows all mappings tagged with both, and so on
* Split out filter_by_tag_path into more useful parts
* When selecting a tag, on the subsequent listing it should be
highlighted
* Include a list of tags that we’re filtering by, with the ability to
click and remove them, one by one
* Make the most_used_tags part re-usable by things that don’t need a
JSON representation
* Use top tags from site rather than overall
* <title> and <h1> should also reflect the filtered state
Paul Hayes
* Put the most important part first
* Include analytics in the title when using the tabs
jamiecobbett added a commit that referenced this pull request Feb 13, 2014
Tag filtering
@jamiecobbett jamiecobbett merged commit 48fd90d into master Feb 13, 2014
1 check passed
1 check passed
default "Build #11 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the tag-filtering branch Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.