Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't obscure the save button when bulk editing lots of mappings #199

Merged
merged 3 commits into from Feb 28, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 26, 2014

  • When selecting many mappings users previously had to scroll a long way to the bottom to save their changes
  • Instead hide mappings after the first 9, and show a link to reveal all of them

screen shot 2014-02-26 at 16 26 12

Paul Hayes added 2 commits Feb 26, 2014
* Before building feature, add extra mappings and ensure tests continue
to pass
* When selecting many mappings users previously had to scroll a long
way to the bottom to save their changes.
* Instead hide mappings after the first 9, and show a link to reveal
all of them
@@ -46,7 +58,7 @@ Feature: Editing multiple mappings for a site
And I go to edit the selected mappings
And I save my changes
And I click the link called "Cancel"
Then I should see "3 mappings"
Then I should see "15 mappings"

This comment has been minimized.

@jamiecobbett

jamiecobbett Feb 27, 2014
Contributor

Why 15? Wouldn't 11 be enough to trigger the behaviour? It would shave some time off the test run too.

This comment has been minimized.

@fofr

fofr Feb 28, 2014
Author Contributor

Updated to 11 😄 (The threshold was higher when the tests were written)

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Feb 27, 2014

This is a really nice feature, good work @fofr

Paul Hayes
* Slightly faster tests
jamiecobbett added a commit that referenced this pull request Feb 28, 2014
Don't obscure the save button when bulk editing lots of mappings
@jamiecobbett jamiecobbett merged commit 910a824 into master Feb 28, 2014
1 check passed
1 check passed
default "Build #133 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the faster-save-from-modal branch Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.