Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter mappings by path, new URL, tag, and type #206

merged 28 commits into from Mar 4, 2014

Filter mappings by path, new URL, tag, and type #206

merged 28 commits into from Mar 4, 2014


Copy link

@fofr fofr commented Mar 3, 2014

  • Show a selection of menus beneath a count of mappings
  • Click menus to reveal quick filter options
  • Filters always add to existing filters
  • Includes a quick option to remove a set of filters or all filters
  • Allow filtering by path and new URL in combination
  • Introduce filtering by type, and link to filtered views from dashboard
  • For non-javascript users include a page with a filter form

screen shot 2014-02-28 at 14 31 41

Paul Hayes added 28 commits Mar 1, 2014
* Link to the page from mappings
* Downscale glyphicons consistently
* Replace the tag-icon specific class with this
* Visited links were still coming through as purple when this class was
* % means the base class doesn’t get extended when using @extend,
prevents colossal selectors
* Extend bootstrap nav-pill to allow non-link options
* Create a compact version of .nav
* Create a filters file
* Remove old form from filters partial
* Hide non-javascript link and create first filter type, path
* Path type links to form in case JavaScript breaks
* Allows user to search by both if they choose
* Simplify existing filter form and move fields into partials for re-use
* Update specs to use path_contains or new_url_contains
* Update features to look for Path field rather than Original path
* Remove ‘remove filter’ link
* Click path to show drop down containing field
* Render a visible path field when searching by path
* Use javascript to prevent bootstrap drop down from hiding when
clicking, and to autofocus field when drop down opened
* Keep filters template lean
* Use a helper to generate the remove link, with a remove icon
* Highlight selected filter in bold with grey background
* Matches path filter behaviour
* Shows filled in form when filtered by
* Include active filter styles to break different filters apart a bit
* When a filter is in a form by itself it needs a button and some
hidden values, rather than the other way around
* Rename with_button to single_filter_form for clarity
* Conditionally include the hidden fields to prevent breaking the
non-js case
* Avoid titleize in filter helper, just use the passed in value
* Keep all filtering in one place
* Show the most popular tags in a drop down
* The drop down remains after filtering, to allow filtering by multiple
* Tag filters remain when filtering by path or new URL
* Quickly remove all active filters
Paul Hayes
* Currently duplicates helper text
* When filter selected its title updates, nothing is shown in the
* Options are all, redirect and archive
* There’s a known problem when searching by New URL and type - New URL
requires mappings to be redirects - selecting archive in this instance
is ignored
* Keep filter logic in one place
* Later this can become an option, eg sort by date edited or hits
* Rename existing path and new url partials to indicate they are form
* This is an incompatible combination of filters
* Include a warning message and remove the archive filter
Copy link

@jamiecobbett jamiecobbett commented Mar 3, 2014

This is dead sexy

jamiecobbett added a commit that referenced this pull request Mar 4, 2014
Filter mappings by path, new URL, tag, and type
@jamiecobbett jamiecobbett merged commit 3a950b4 into master Mar 4, 2014
1 check passed
1 check passed
default "Build #145 succeeded on Jenkins"
@jamiecobbett jamiecobbett deleted the filters branch Mar 4, 2014
Copy link

@jamiecobbett jamiecobbett commented Mar 4, 2014

Awesome work @fofr ✈️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.