Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default hits to last 30 days instead of all time #207

Merged
merged 1 commit into from Mar 5, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 4, 2014

  • Switch from All time to Last 30 days
  • Show more relevant errors and load pages faster
  • Tweak feature so there’s a difference between 30 days and all time
  • Use Timecop to freeze time in feature and specs
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 4, 2014

(We might want to postpone merging this until the more complex mappings to hits work is merged)

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Mar 4, 2014

LGTM, and yes, on the off-chance let's wait until the other PR is merged.

* Switch from All time to last 30 days
* Show more relevant errors and load pages faster
* Tweak feature so there’s a difference between 30 days and all time
* Use Timecop to freeze time in feature and specs
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 5, 2014

Rebased with master, good to go.

jamiecobbett added a commit that referenced this pull request Mar 5, 2014
Default hits to last 30 days instead of all time
@jamiecobbett jamiecobbett merged commit ae34f2d into master Mar 5, 2014
1 check passed
1 check passed
default "Build #172 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the update-default-analytics-time branch Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.