Change the message for removing all tags from mappings #210

Merged
merged 1 commit into from Mar 10, 2014

Conversation

Projects
None yet
3 participants
Owner

issyl0 commented Mar 7, 2014

  • The message reads: "Tags removed from num_x mappings".
  • This is an alternative to "Tags a and b removed from num_x
    mappings", which I don't think could be done due to tag_list being
    blank at the time of saving when tags are deleted.
Change the message for removing all tags from mappings
- The message reads: "Tags removed from num_x mappings".
- This is an alternative to "Tags a and b removed from num_x
  mappings", which I don't think could be done due to tag_list being
  blank at the time of saving when tags are deleted.
+ if tag_list.blank?
+ "Tags removed from #{successes} #{ 'mapping'.pluralize(successes) }"
+ else
+ "#{successes} #{ 'mapping'.pluralize(successes) } tagged “#{tag_list}"
@issyl0

issyl0 Mar 7, 2014

Owner

The reasoning behind the spaces between #{ and 'mapping' is that I followed the example of the original line. Should I remove the spaces to make it look neater?

Member

fofr commented Mar 7, 2014

Looks good to me 👍

@issyl0 issyl0 closed this Mar 7, 2014

@issyl0 issyl0 reopened this Mar 7, 2014

Owner

issyl0 commented Mar 7, 2014

Oops. Accidentally closed. Now reopened. And 👍 @fofr.

jamiecobbett added a commit that referenced this pull request Mar 10, 2014

Merge pull request #210 from alphagov/fix_all_tags_removed_message
Change the message for removing all tags from mappings

@jamiecobbett jamiecobbett merged commit 68206bc into master Mar 10, 2014

1 check passed

default "Build #183 succeeded on Jenkins"
Details

@jamiecobbett jamiecobbett deleted the fix_all_tags_removed_message branch Mar 10, 2014

Owner

issyl0 commented Mar 10, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment