Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mappings header to top when scrolling #212

Merged
merged 1 commit into from Mar 10, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 7, 2014

  • When scrolling past a mapping table header, it fixes to the top to
    avoid losing context whilst editing mappings
  • Only applies to tables not in a modal
  • Increase mapping type column size to prevent re-sizing when table
    header toggles
Paul Hayes
* When scrolling past a mapping table header, it fixes to the top to
avoid losing context whilst editing mappings
* Only applies to tables not in a modal
* Increase mapping type column size to prevent re-sizing when table
header toggles
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Mar 10, 2014

Do you have a feel for how well this works on older machines? What about IE8?

@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 10, 2014

Just tested in IE8, all seems smooth and working. Tried out other browsers too, including iOS. All seems good to me.

jamiecobbett added a commit that referenced this pull request Mar 10, 2014
Fix mappings header to top when scrolling
@jamiecobbett jamiecobbett merged commit 8d37ea4 into master Mar 10, 2014
1 check passed
1 check passed
default "Build #186 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the fix-buttons-to-top branch Mar 10, 2014
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Mar 10, 2014

I guess that means you could call it a smooth operator http://www.youtube.com/watch?v=4TYv2PhG89A&feature=kp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.