Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show transition in desktop mode on IE8 and below #213

Merged
merged 2 commits into from Mar 13, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 12, 2014

screen shot 2014-03-12 at 18 31 46

@@ -72,5 +72,6 @@ class Application < Rails::Application
# Version of your assets, change this if you want to expire all your assets
config.assets.version = '1.0'
config.assets.precompile += %w(html5.js)
config.assets.precompile += %w(respond.min.js)

This comment has been minimized.

@jamiecobbett

jamiecobbett Mar 13, 2014
Contributor

The asset pipeline will minimise files, so I believe there's no benefit to using minified versions. The primary benefit I can see is that non-minified will be more intelligible in a debugger in development. Do you think it's worth switching?

This comment has been minimized.

@fofr

fofr Mar 13, 2014
Author Contributor

I don't think it's worth switching. (html5.js is also minimised)

jamiecobbett added a commit that referenced this pull request Mar 13, 2014
Show transition in desktop mode on IE8 and below
@jamiecobbett jamiecobbett merged commit 6a690c3 into master Mar 13, 2014
1 check passed
1 check passed
default "Build #196 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the ie8-respondjs branch Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.