Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After editing mappings via hits, return to hits #216

Merged
merged 1 commit into from Mar 14, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 13, 2014

  • When a user is editing mappings via hits, then the best place to return them to is where they came from
  • Use the return_url parameters as mappings links do
  • Use absolute paths for partials to avoid missing partial errors when rendering modal on hits pages
  • Pass the return_url through from find method to new/edit methods
* Use the return_url parameters as mappings links do
* Use absolute paths for partials to avoid missing partial errors when
rendering modal on hits pages
* Pass the return_url through from find method to new/edit methods
jamiecobbett added a commit that referenced this pull request Mar 14, 2014
After editing mappings via hits, return to hits
@jamiecobbett jamiecobbett merged commit 53538f8 into master Mar 14, 2014
1 check passed
1 check passed
@govuk-ci
default "Build #203 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the return-to-hits branch Mar 14, 2014
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 14, 2014

💝

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Mar 14, 2014

This is a nice UX change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants