Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapping validation styles [57569316] #25

Merged
merged 2 commits into from Sep 27, 2013

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 27, 2013

  • Remove bootstrap grid class from error message
  • Remove wrapping element and grid class from edit form
Paul Hayes added 2 commits Sep 27, 2013
* It was creating a 30px padding that misaligned with the header
* It was causing float problems
* The error message can go full width now, though this doesn't always
look great
@rgarner
Copy link
Contributor

@rgarner rgarner commented Sep 27, 2013

This looks good here. Those spans were a hangover from having our versions table to the right of our edit form until quite recently. Good that they're gone.

Paging @jamiecobbett, this is good to merge

jamiecobbett added a commit that referenced this pull request Sep 27, 2013
@jamiecobbett jamiecobbett merged commit a29dfa1 into master Sep 27, 2013
@jamiecobbett jamiecobbett deleted the mapping-validation-styles-57569316 branch Sep 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.