Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering of organisation list #250

Merged
merged 2 commits into from Apr 14, 2014
Merged

Allow filtering of organisation list #250

merged 2 commits into from Apr 14, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 10, 2014

In user research it was noted that finding organisations in the list has become difficult, it’s grown quite long. This filter helps find organisations quickly.

  • Hide table rows that don’t match the input
  • JavaScript only, the field is hidden when JS is disabled
  • Prevent sideways shifting when page length changes and scrollbars hide/show
</th>
<th scope="col">Sites</th>
</tr>
<tr class="hide-if-no-js table-header-secondary">

This comment has been minimized.

@jamiecobbett

jamiecobbett Apr 14, 2014
Contributor

This doesn't appear to be working - if I disable JavaScript, the box is still there but doesn't work.

This comment has been minimized.

@fofr

fofr Apr 14, 2014
Author Contributor

Fixed with rebase.

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Apr 14, 2014

This is nice 👍

Paul Hayes added 2 commits Apr 10, 2014
In user research it was noted that finding organisations in the list
has become difficult, it’s grown quite long. This filter helps find
organisations quickly.

* Hide table rows that don’t match the input
* JavaScript only, the field is hidden when JS is disabled
* Prevent sideways shifting when page length changes and scrollbars
hide/show
Paul Hayes
jamiecobbett added a commit that referenced this pull request Apr 14, 2014
Allow filtering of organisation list
@jamiecobbett jamiecobbett merged commit e213ed7 into master Apr 14, 2014
1 check passed
1 check passed
default "Build #388 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the filter-orgs-list branch Apr 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.