Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip out trailing slashes when filtering #255

Merged
merged 1 commit into from Apr 30, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 14, 2014

  • Fix #68376922
  • Or more specifically, put trailing slashes back after canonicalising

An example of the original problem:
“When trying to filter path on /sta/, it filters on /sta. As a result, "/statistics" ends up included in my "/sta/" mappings list, when all I want is /sta/ things for the Standards and Testing Agency”

* Fix #68376922
* Or more specifically, put trailing slashes back after canonicalising

An example of the original problem:
“When trying to filter path on /sta/, it filters on /sta. As a result,
"/statistics" ends up included in my "/sta/" mappings list, when all I
want is /sta/ things for the Standards and Testing Agency”
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Apr 16, 2014

I think the trade-off here is where the user has pasted in a full path including a trailing slash - they wouldn't find the mapping they're looking for. This does seem marginal though.

@fofr
Copy link
Contributor Author

@fofr fofr commented Apr 25, 2014

@jennyd Do you have any objections to this? Can it be merged?

jamiecobbett added a commit that referenced this pull request Apr 30, 2014
Don't strip out trailing slashes when filtering
@jamiecobbett jamiecobbett merged commit 893c006 into master Apr 30, 2014
1 check passed
1 check passed
default "Build #389 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the filter-with-trailing-slash branch Apr 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.