Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL hosts must contain at least one "." #256

Merged
merged 1 commit into from Apr 14, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 14, 2014

We started prepending http:// to the start of URL values so the user didn’t have to. This left a hole in our validation where “something” would become “http://something” and pass validation checks.

  • Check host contains at least one period, mostly to prevent accidents
Paul Hayes
We started prepending http:// to the start of URL values so the user
didn’t have to. This left a hole in our validation where “something”
would become “http://something” and pass validation checks.

* Check host contains at least one period, mostly to prevent accidents
jamiecobbett added a commit that referenced this pull request Apr 14, 2014
URL hosts must contain at least one "."
@jamiecobbett jamiecobbett merged commit ffa4747 into master Apr 14, 2014
1 check passed
1 check passed
default "Build #390 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the new-urls-must-contain-a-dot branch Apr 14, 2014
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Apr 14, 2014

Worth saying that a dot in a hostname isn't strictly required, but in practice we'll never have URLs without them. The trade-off is totally worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.