Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put transition date on analytics graph #260

Merged
merged 1 commit into from Apr 22, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 17, 2014

  • Show a line on the analytics graph on the date at which the site mappings went live
  • Only show a line when site is live and the graph spans the date of transition

screen shot 2014-04-17 at 16 15 29
screen shot 2014-04-17 at 16 15 43

it { should_not include('nil') }

context 'it includes a normal data row' do

This comment has been minimized.

@jamiecobbett

jamiecobbett Apr 22, 2014
Contributor

This doesn't seem like an appropriate use of context. describe would be better.

This comment has been minimized.

@fofr

fofr Apr 22, 2014
Author Contributor

Fixed.

{ label: 'Date', type: 'date' },

# Annotation line for transition date
{ label: 'Line', type: 'string', p: {role: 'annotation'}}

This comment has been minimized.

@jamiecobbett

jamiecobbett Apr 22, 2014
Contributor

Could we change the value of label to "Transition date"? Then we wouldn't need the comment.

This comment has been minimized.

@fofr

fofr Apr 22, 2014
Author Contributor

"Line" renamed to "Transition date line"

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Apr 22, 2014

I like this a lot 👍

Paul Hayes
* Show a line on the analytics graph on the date at which the site
mappings went live
* Only show a line when site is live and the graph spans the date of
transition
jamiecobbett added a commit that referenced this pull request Apr 22, 2014
Put transition date on analytics graph
@jamiecobbett jamiecobbett merged commit f322891 into master Apr 22, 2014
1 check passed
1 check passed
default "Build #436 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the transition-date-on-graph branch Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.