Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up bulk add success messages #261

Merged
merged 1 commit into from Apr 22, 2014
Merged

Tidy up bulk add success messages #261

merged 1 commit into from Apr 22, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 22, 2014

  • When all are updated, don’t mention “0 created”
  • When both updating and creating, don’t show a broken tagged message
    (“1 updated and 1 created. All .”)
  • When tagging, conditionally append “All ” to the start of the
    tagged_with string
  • When only “1 mapping updated”, remove the full stop as the message is
    effectively a title.
Paul Hayes
* When all are updated, don’t mention “0 created”
* When both updating and creating, don’t show a broken tagged message
(“All .”)
* When tagging, conditionally append “All “ to the start of the
tagged_with string
* When only “1 mapping updated”, remove the full stop as the message is
effectively a title.
jamiecobbett added a commit that referenced this pull request Apr 22, 2014
@jamiecobbett jamiecobbett merged commit 41994bd into master Apr 22, 2014
1 check passed
1 check passed
default "Build #438 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the fix-broken-modal-title branch Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.