Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine background bulk add modal #263

merged 4 commits into from Apr 28, 2014


Copy link

@fofr fofr commented Apr 25, 2014

  • Move javascript code into module
  • Clean up styles
  • Add javascript tests
  • Include a success state
Paul Hayes added 4 commits Apr 24, 2014
* Switch from inline JS to a module
* Pull URL from data attribute
* Switch from setInterval to a timeout that gets set once the previous
request is complete
* Reduce scope of jQuery selectors to just the element we’re looking at
* Create a spec

Not yet handling errors, updating aria values or handling completion
* Take out inline styles
* Use default inherited styles where possible
* Make some specific styles for this modal
* Refactor modal CSS that deals with absolutely positioned close buttons
* Make the modal-saved-mappings CSS re-usable, and remove the specific
font-size: 80% rule on the glyphicon
* When done matches total, stop making requests, show a success state
and shut down the module
* Use jasmine clock to avoid having to wait 1 second for each timeout
jamiecobbett added a commit that referenced this pull request Apr 28, 2014
Refine background bulk add modal
@jamiecobbett jamiecobbett merged commit f89971f into background_bulk_add Apr 28, 2014
1 check passed
1 check passed
default "Build #470 succeeded on Jenkins"
@jamiecobbett jamiecobbett deleted the background_bulk_add_modal branch Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.