Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make switching between hit periods work without JavaScript #269

Merged
merged 5 commits into from May 2, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 1, 2014

  • Dispense with the drop down, use a tertiary navigation pattern based on bootstraps navbar
  • Works without JavaScript
  • Makes time period options clearer and is a better indication of which is selected
  • On mobile/thin page widths it makes use of the collapsible menu pattern as used in the page header

screen shot 2014-05-01 at 17 52 16
screen shot 2014-05-01 at 17 52 05

Paul Hayes added 5 commits May 1, 2014
* Dispense of the drop down, use a tertiary navigation pattern based on
bootstraps navbar
* Works without JavaScript
* Makes time period options clearer and is a better indication of which
is selected
* On mobile/thin page widths it makes use of the collapsible menu
pattern as used in the page header
* Improve page outline
* Elaborate on meaning of certain links using hidden text
* Add a header for the time period switcher
* Add a header for the hits section
* Make following summary sections one header level lower
* It’s no longer a drop down
* When clicking a point on a hits graph you can filter the view by that
date. The date wasn’t showing.
jamiecobbett added a commit that referenced this pull request May 2, 2014
Make switching between hit periods work without JavaScript
@jamiecobbett jamiecobbett merged commit 7e07f75 into master May 2, 2014
1 check passed
1 check passed
@govuk-ci
default "Build #523 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the hits-no-js branch May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants