Skip to content

/ transition

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show environment indicator #305

Merged
merged 3 commits into from Jun 6, 2014
Merged

Show environment indicator #305

merged 3 commits into from Jun 6, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 5, 2014

  • Upgrade to latest version of admin gem
  • Distinguish between Preview and Production so that users don't accidentally make changes to Production content whilst under the assumption they're working on Preview.
    • This requires some initialisers to be set at deploy time (see Publisher example)
  • Highlight environment using a favicon, a coloured navigation bar and a coloured label
  • Create a custom [T] transition favicon

screen shot 2014-06-05 at 12 34 02
@issyl0
Copy link
Contributor

@issyl0 issyl0 commented Jun 6, 2014

Looks good! ☀️
Paul Hayes added 3 commits Jun 5, 2014
Paul Hayes @rgarner
Upgrade admin gem to 0.1.0
c016cc2 
* Fix broken footer html
* Fix visited link styles on bootstrap components
* Get environment indicator styles
Paul Hayes @rgarner
Add custom Transition favicons
9fce16a
Paul Hayes @rgarner
Use gem's "link-inherit"
Loading status checks…
6cece3a 
* Replaces the more specific glossary link style
@rgarner
Copy link
Contributor

@rgarner rgarner commented Jun 6, 2014

I see the "T" favicon, but I don't see the label locally.
@rgarner
Copy link
Contributor

@rgarner rgarner commented Jun 6, 2014

Ok, from conversation with @fofr, if you see this locally, rm -Rf tmp/cache and restart. Shouldn't be a problem on deploy.
@rgarner
Copy link
Contributor

@rgarner rgarner commented Jun 6, 2014

What are the initialisers that need to be set? Can you link to an example?
@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 6, 2014

@rgarner The examples are on a private deployment repo. There was a link, but I removed it. @alext is best placed to help.
@benilovj
Copy link
Contributor

@benilovj benilovj commented Jun 6, 2014

@rgarner see https://github.gds/gds/alphagov-deployment/pull/614
@rgarner
Copy link
Contributor

@rgarner rgarner commented Jun 6, 2014

Thanks @benilovj - not something I have permission to, though.
rgarner added a commit that referenced this pull request Jun 6, 2014
@rgarner
Merge pull request #305 from alphagov/environment-indicator
Loading status checks…
9849f98 
Show environment indicator
@rgarner rgarner merged commit 9849f98 into master Jun 6, 2014
1 check passed
1 check passed
default "Build #821 succeeded on Jenkins"
Details
@rgarner rgarner deleted the environment-indicator branch Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@fofr @issyl0 @rgarner @benilovj
You can’t perform that action at this time.