Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand the header #31

Merged
merged 2 commits into from Oct 2, 2013
Merged

Brand the header #31

merged 2 commits into from Oct 2, 2013

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 1, 2013

  • Add crown and new transport to header
Paul Hayes added 2 commits Oct 1, 2013
* Rename colours scss to theme
* Add the transport font stack and reference in scaffolds
* Switch header text to New Transport
* Add crown logo
* Port from Publisher app
* Brings app inline with other admin tools
@alext
Copy link
Contributor

@alext alext commented Oct 1, 2013

The font won't work without the webfont files. Having said that, we don't use the font on our admin sites, only the public facing part of the site.

@fofr
Copy link
Contributor Author

@fofr fofr commented Oct 1, 2013

@alext We are already using NTA within transition, this is refining it to be used in the header. (See https://github.com/alphagov/transition/blob/master/app/views/layouts/application.html.erb#L16-L30 for the assets being used).

I noticed some of the admin sites were using Gill Sans, but questioned whether that would remain the case. As transition was already using NTA I assumed that it would change.

@alext
Copy link
Contributor

@alext alext commented Oct 1, 2013

We shouldn't be referencing assets across projects like that. There's no way to ensure that you keep up to date with any changes. In fact a lot of that template looks wrong. If the transition app needs to use the GOV.UK look and feel, it should be using govuk_template and govuk_frontend_toolkit, not hotlinking to assets with static.

There's still the question on whether an admin tool should be using the GOV.UK look and feel. We should also clarigy the licensing on the font. I believe we have a licence to use it on *.gov.uk, but not elsewhere. @antimega will be able to clarify that.

@bradwright
Copy link

@bradwright bradwright commented Oct 1, 2013

Leaving aside the questions of what look and feel is right, what @alext said is correct - you should be using those libraries if you want to use the GOV.UK look and feel/assets.

@jystewart
Copy link

@jystewart jystewart commented Oct 1, 2013

In terms of font licensing: we should proceed on the assumption that our various admin tools will be moving to a *.service.gov.uk domain at some stage (hopefully soon), and so the font license will cover them.

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Oct 2, 2013

I'm going to merge this as the discussion isn't related to the change but to code that was already present. We've had a discussion and @fofr is going to resolve all of what's been discussed separately.

jamiecobbett added a commit that referenced this issue Oct 2, 2013
@jamiecobbett jamiecobbett merged commit 3dc1cf3 into master Oct 2, 2013
@jamiecobbett jamiecobbett deleted the crown-the-header branch Oct 2, 2013
@fofr
Copy link
Contributor Author

@fofr fofr commented Oct 2, 2013

The basic plan, as discussed with @jamiecobbett and @rgarner is to:

  • Remove New Transport from transition and revert back to using Gill Sans/Helvetica ala Publisher
  • Stop linking assets from other projects (favicons, HTML5 Shiv, etc.) and include them ourselves

(cc'ing @workwithgreat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants