Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade admin gem to 1.0.0 #317

Merged
merged 4 commits into from Jun 18, 2014
Merged

Upgrade admin gem to 1.0.0 #317

merged 4 commits into from Jun 18, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 13, 2014

  • Upgrade gem
  • Fix visited link specificity
  • Remove silent margin classes and replace with mixins
  • Explicitly pad list-item-groups on site dashboard, rather than extend the base Bootstrap styles
Paul Hayes added 4 commits Jun 13, 2014
* Mixins aren’t using !important
* Generated CSS is cleaner
* Silent classes have been removed from admin gem
* Before the default Bootstrap styles were being modified
* Instead use new admin gem helper class
* Increased specificity of visited link styles in admin gem caused
filter options to go blue, prevent this from happening again
jamiecobbett
Copy link
Contributor

jamiecobbett commented on 2ee8e61 Jun 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message body doesn't seem to relate to the commit

rgarner
Copy link
Contributor

rgarner commented on 2ee8e61 Jun 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the top two bullets relate to the overall effect to the admin gem, the last one (re: the silent classes) applies specifically to the change in interface required here.

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Jun 16, 2014

Otherwise this is good to merge.

rgarner added a commit that referenced this issue Jun 18, 2014
@rgarner rgarner merged commit 3b74adc into master Jun 18, 2014
1 check passed
@rgarner rgarner deleted the upgrade-admin-gem branch Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants