Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the aria-valuenow on batch upload #371

Merged
merged 1 commit into from Aug 5, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 5, 2014

  • Bootstrap styles based on aria-valuenow="0", which we weren’t updating, so those transparent styles were persisting.
  • Rather than overwriting those styles with something more specific we should be updating the aria value for accessibility.
Paul Hayes
* Bootstrap styles based on aria-valuenow=“0”, which we weren’t
updating, so those transparent styles were persisting.
* Rather than overwriting those styles with something more specific we
should  be updating the aria value for accessibility.
@issyl0
Copy link
Contributor

@issyl0 issyl0 commented Aug 5, 2014

This makes the progress bars green again. \o/

@jennyd
Copy link
Contributor

@jennyd jennyd commented Aug 5, 2014

How did we break this when doing import mappings?

@issyl0
Copy link
Contributor

@issyl0 issyl0 commented Aug 5, 2014

We didn't. Bootstrap did. @fofr can elaborate.

@fofr
Copy link
Contributor Author

@fofr fofr commented Aug 5, 2014

Bootstrap 3.2 introduced a specific style that used the aria value to hide the background colour when at 0%. We however weren't updating that value, so the colour was always hidden. So, Transition has always had a bug where it wasn't updating aria values, it just wasn't apparent until now.

Nothing to do with import mappings.

jamiecobbett added a commit that referenced this pull request Aug 5, 2014
Update the aria-valuenow on batch upload
@jamiecobbett jamiecobbett merged commit 4286303 into master Aug 5, 2014
1 check passed
1 check passed
default "Build #1397 succeeded on Jenkins"
Details
@jamiecobbett jamiecobbett deleted the fix-progress-aria branch Aug 5, 2014
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Aug 5, 2014

Thanks @fofr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.