Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local assets over external ones [58158124] #40

Merged
merged 4 commits into from Oct 8, 2013
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 7, 2013

  • Remove links to the following external assets:
    • New transport font
    • HTML5 shiv
    • Favicon
    • App icons and open graph images
  • Use local favicon and HTML5 shiv
  • Update styles to use Gill Sans instead of New Transport
  • Remove duplicate meta viewport tag
  • Brings app styles further inline with older admin apps (eg publisher), holds off on any potential updates to admin app styles
Paul Hayes added 4 commits Oct 7, 2013
* Keep topmost viewport tag, remove decimal point from initial-scale
* Remove external CDN version
* Remove duplicate which was linking to external assets
* Use the latest version, 3.7.0
* Add favicon to image assets
* Remove external references to app icons and og:image
* Remove links to external font files and IE fallbacks
* Default headers to Helvetica (bootstrap default)
* Apply Gill Sans to the nav bar and tweak spacing
* This brings transition app inline with other admin apps, and holds
off on any potential migration to using new transport in the future.
jamiecobbett added a commit that referenced this pull request Oct 8, 2013
Use local assets over external ones [58158124]
@jamiecobbett jamiecobbett merged commit 47edf65 into master Oct 8, 2013
@jamiecobbett jamiecobbett deleted the use-local-assets branch Oct 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.