Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create summary and filtered views of hits data [58805750] #49

merged 14 commits into from Oct 22, 2013


Copy link

@fofr fofr commented Oct 18, 2013

  • Create errors, archives, redirects and "other" pages for filtered views of hits
  • Show top ten of each on a summary page
  • Link to the summary from the organisation page
Paul Hayes and others added 14 commits Oct 16, 2013
* Prior to removing the View Hits link, which will point to the
summary, update the all hits feature to go directly to the all hits page
* Show top ten errors, archives and redirects on a single page
* Remove pagination from hits partial so it can be reused on the summary
* Stop misusing pagination
* New pages for errors, archives and redirects
* Move hits view into a partial for re-use across pages
* Stick with convention
* Avoid a potential clash with host.hits_data
* Make it easier to spot if something is being missed by our most
common http status codes
* Most common example: 200
* Use #limit instead of #take to limit at server-side
* Convert to arrays in controller to avoid view issuing count queries
* Group by path_hash rather than path in aggregate query
* We are showing a paginated list of unique paths, not hits
* A count of hits would be much higher

This comment has been minimized.

Copy link

@jennyd jennyd commented on e3c93d4 Oct 22, 2013

Don't worry about it this time, but it's generally better for removal of trailing whitespace to be in a separate commit, so that it's easier to see what's actually changing (especially on the command line).


This comment has been minimized.

Copy link

@jennyd jennyd commented on 94143fe Oct 22, 2013

👍 I think in general we should be explicit and use 'HTTP status' in future - we're starting to talk about other kinds of statuses in various contexts and it would help to avoid confusion (in code too, not just user-facing things).

Copy link

@jennyd jennyd commented Oct 22, 2013


jennyd added a commit that referenced this pull request Oct 22, 2013
Create summary and filtered views of hits data [58805750]
@jennyd jennyd merged commit 5028f46 into master Oct 22, 2013
@jennyd jennyd deleted the traffic-summary branch Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.