Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sass to 3.4.14 #495

Merged
merged 1 commit into from Jun 18, 2015
Merged

Bump Sass to 3.4.14 #495

merged 1 commit into from Jun 18, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 18, 2015

bootstrap-sass appears to have included a sass 3.3 specific rule
(@at-root) in a minor release update: alphagov/govuk_admin_template#70

The affect of this is that the glyphicons font doesn't render. See the above issue for more details.

  • Update to the latest version of Sass, 3.4 so that the bootstrap sass compiles correctly and the glyphicons load
Paul Hayes
`bootstrap-sass` appears to have included a SASS 3.3 specific rule
(@at-root) in a minor release update.

We’re pinned to an older version of SASS which is a couple of years out
of date.
jennyd added a commit that referenced this pull request Jun 18, 2015
@jennyd jennyd merged commit 35cd212 into master Jun 18, 2015
1 check passed
1 check passed
default "Build #2229 succeeded on Jenkins"
Details
@jennyd jennyd deleted the bump-sass branch Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.