Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimise use of HTTP status codes [60348822] #66

Merged
merged 8 commits into from
Nov 15, 2013

Conversation

fofr
Copy link
Contributor

@fofr fofr commented Nov 14, 2013

  • Change HTTP status to a Type column on mappings, with redirects and archives
  • Improve legibility of mappings table
  • Move edit column to right to match hits, and change link to a button
  • Cleanup edit/add mapping form
  • Favour types over status codes in edit mapping form
  • On hits, use an abbreviation to explain the status code

Paul Hayes added 8 commits November 14, 2013 16:08
* Make the redirect target on mappings grey to aid scanning the
mappings list
* It also declutters the list and makes it clear which part is
responsible for the mapping
* Grey matches existing redirect text
* 301 is now Redirect, 410 is Archive
* Move edit link to right hand column, aligned with add mapping button
and the check mapping option on hits
* Make edit link a button
* Rename HTTP status column to type
* Add the same redirect/archive colour coding as used on hits to
distinguish mapping types
* Use the right margin property
* Matches new sites table
* Use the same terminology as the mappings page, but keep the HTTP
meanings for the more technical
* Use bootstrap form pattern to clarify path field
* Rename label to Old URL now the form is clearer
* Distinguish between saving and creating on the form button
* Include helpful placeholders
* Mitigate some of the confusion about hit status codes by including
the default meaning as a title attribute
* Update corresponding tests
@rgarner
Copy link
Contributor

rgarner commented Nov 14, 2013

This looks very nice, especially the matching colour coding. The only thing that worries me about it is that we do use HTTP status codes in Analytics / Hits and now users with no HTTP experience don't have any way of making the mental connection that 410 means Archive or 301 means Redirect.

@fofr
Copy link
Contributor Author

fofr commented Nov 14, 2013

Except that all archives are in a block under the heading "Archives", or under a tab named "Archives". Although this isn't the case on the All tab.

I accept this isn't ideal. One option is to remove that column altogether from the categories, with the exception of Other, a section which isn't proving useful and could be removed.

http://<%= @site.default_host.hostname %><%= f.text_field :path, class: 'span8' %>
<%= f.label :path, 'Old URL', class: 'add-top-margin' %>
<div class="input-prepend add-bottom-margin">
<span class="add-on">http://<%= @site.default_host.hostname %></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving this :)

@jamiecobbett
Copy link
Contributor

Regarding @rgarner's comment about the Mappings and Hits tables now being inconsistent, I agree that it isn't ideal, but is acceptable given that @fofr is planning to rework the Hits pages imminently. On that basis I'm going to merge as-is.

jamiecobbett added a commit that referenced this pull request Nov 15, 2013
Minimise use of HTTP status codes [60348822]
@jamiecobbett jamiecobbett merged commit b62abe8 into master Nov 15, 2013
@jamiecobbett jamiecobbett deleted the consistent-mapping-terminology branch November 15, 2013 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants