New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ajax request for broken links #1341
Conversation
016a70b
to
dbec18d
Compare
This is currently just a placeholder until we have redesigned the view to not be one form. This is done to prevent the form from refreshing without the user saving their changes
dbec18d
to
8e190b3
Compare
35ff5bc
to
b59cd69
Compare
b59cd69
to
ab8f65d
Compare
This will probably get deleted once we redesigned the page |
.innerHTML = '<strong>Please wait. Broken link report in progress.</strong><br/><br/>Refresh the page to view to see the result.' | ||
.querySelector('.js-broken-links__content') | ||
.innerHTML = '<p class="govuk-body"><strong>Please wait. Broken link report in progress.</strong></p>' + | ||
'<p class="govuk-body">Refresh the page to view to see the result.</p>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to let the user know they will lose any unsaved changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will be nice to let the user know.
I'm not sure it's related to the frontend implementation, but if you fix the links and refresh the report you still see the broken links. Just going to have a dig into it and see if it's an easy fix. I'm wondering whether it's a local issue. I'll deploy the branch and check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's that one question about letting the user know, but like for like this is working really nicely!
This is currently just a placeholder until we have redesigned the view to not be one form.
This is done to prevent the form from refreshing without the user saving their changes
https://trello.com/c/e7v57JL5/436-add-ajax-to-broken-links