Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ajax request for broken links #1341

Merged
merged 5 commits into from May 17, 2022
Merged

Adds ajax request for broken links #1341

merged 5 commits into from May 17, 2022

Conversation

DilwoarH
Copy link
Contributor

@DilwoarH DilwoarH commented May 11, 2022

This is currently just a placeholder until we have redesigned the view to not be one form.

This is done to prevent the form from refreshing without the user saving their changes

Screenshot 2022-05-11 at 3 03 54 pm

Screenshot 2022-05-11 at 3 04 22 pm

https://trello.com/c/e7v57JL5/436-add-ajax-to-broken-links

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@DilwoarH DilwoarH force-pushed the broken-links-ajax branch 2 times, most recently from 016a70b to dbec18d Compare May 11, 2022 12:04
This is currently just a placeholder until we have redesigned the view to not be one form.

This is done to prevent the form from refreshing without the user saving their changes
@DilwoarH DilwoarH force-pushed the broken-links-ajax branch 2 times, most recently from 35ff5bc to b59cd69 Compare May 11, 2022 14:03
@DilwoarH
Copy link
Contributor Author

This will probably get deleted once we redesigned the page

@DilwoarH DilwoarH requested a review from kevindew May 11, 2022 14:14
.innerHTML = '<strong>Please wait. Broken link report in progress.</strong><br/><br/>Refresh the page to view to see the result.'
.querySelector('.js-broken-links__content')
.innerHTML = '<p class="govuk-body"><strong>Please wait. Broken link report in progress.</strong></p>' +
'<p class="govuk-body">Refresh the page to view to see the result.</p>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to let the user know they will lose any unsaved changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will be nice to let the user know.

@davidgisbey
Copy link
Contributor

davidgisbey commented May 16, 2022

I'm not sure it's related to the frontend implementation, but if you fix the links and refresh the report you still see the broken links. Just going to have a dig into it and see if it's an easy fix.

I'm wondering whether it's a local issue. I'll deploy the branch and check.

Copy link
Contributor

@davidgisbey davidgisbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's that one question about letting the user know, but like for like this is working really nicely!

@DilwoarH DilwoarH merged commit e0fb1b4 into main May 17, 2022
@DilwoarH DilwoarH deleted the broken-links-ajax branch May 17, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants