Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using govuk_admin_template #60

Merged
merged 17 commits into from May 30, 2014
Merged

Switch to using govuk_admin_template #60

merged 17 commits into from May 30, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 30, 2014

  • Upgrade from Bootstrap 2 to Bootstrap 3
  • Upgrade jQuery, jQuery UI, formtastic, formtastic-bootstrap
    • Switch from using deprecated commit_button
  • Update javascript to work with latest jQuery
    • live is deprecated
  • Update markup to conform with newest bootstrap patterns
    • Accordion pattern when editing an edition becomes a set of rearrangeable panels
  • Add breadcrumbs for easier navigation
  • Remove CSS for sorted tables, history diff view and others — features aren't in this app
fofr added 17 commits May 29, 2014
* Use SASS rather than LESS
* Use modern versions of formtastic
* Delete old LESS styles
* Include admin gem styles
* Update application.html to use content_for
* Add table-header class for better header contrast
* Add a breadcrumb
* Use page-title class and H1s for page titles
* Formtastic replaced commit_button with action
* Replace spanX with col-md-X
* Use fixed container grids rather than fluid (pages are still
responsive)
* Remove the unnecessary col-md-12 grid column and replace with a row
class
* Remove the unused <div> wrapper
* Add some spacing between tabs and tab content with admin gem class
* Keep the help text limited to 200px
* This isn’t exactly usable, but it’s the status quo
* Assign listeners to body and move the selector to the second
parameter of the “on” call
* As recommended by http://api.jquery.com/live/
* Bootstrap 3 uses collapsing panels to build an accordion:
http://getbootstrap.com/javascript/#collapse-examples
* Use a `js-` prefixed class as the handle for sortable items
* Upgrade jQuery UI library to work with newer jQuery (1.8.20 to
1.10.4) — only includes ui.sortable, ui.accordion and core
* Use a CSS animation for the yellow fade effect
* This feature currently times out on preview/live, it’s not
necessarily being used
* These changes bring the form inline with Bootstrap 3
* Cleanup some of the JS to not use IDs
* Minimum necessary to get feature working from a front-end point of
view
* Put back CSS that was removed from the .less file
* Increase the line-height slightly from 21px to 26px for better
readability
* Use bootstrap 3 panels for each version
* Correct spacing between add note button and textarea
* Split up the fields with a bit of extra margin using gem helper class
@bishboria
Copy link
Contributor

@bishboria bishboria commented May 30, 2014

Everything seems to be in order.

bishboria added a commit that referenced this pull request May 30, 2014
Switch to using govuk_admin_template
@bishboria bishboria merged commit 5a0f8ad into master May 30, 2014
@bishboria bishboria deleted the govuk_admin_template branch May 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.