Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jasmine for Javascript testing #65

Merged
merged 6 commits into from Jul 16, 2014
Merged

Add Jasmine for Javascript testing #65

merged 6 commits into from Jul 16, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 15, 2014

  • Configure to avoid default phantomjs download
  • Run javascript tests by default
  • Include govuk-admin-template as jasmine src file
  • Create tested modules for sorting the parts of a publication, and for converting titles to slugs
  • Remove some unnecessary JS related to collapsing parts
fofr added 6 commits Jul 11, 2014
* Run `rails g jasmine:install`
* Configure to avoid default phantomjs download
* Run javascript tests by default
* Required for bootstrap and jquery libraries to be present
* Move into separate file
* Create a spec to test title to slug conversion
* We were using the `in` class to say that an accordion part should be
open, then collapsed all parts using JavaScript. We can simply omit the
`in` to do the same thing.
* Remove the `data-parent` attribute to allow multiple parts to be open
at once. See http://getbootstrap.com/javascript/#collapse
* Move sortable js into a re-usable module with tests
* Add comments to indicate that it’s using jQuery UI
* Test that highlights are added and that input order is updated after
sorting
dhwthompson added a commit that referenced this pull request Jul 16, 2014
Add Jasmine for Javascript testing
@dhwthompson dhwthompson merged commit 6744166 into master Jul 16, 2014
@dhwthompson dhwthompson deleted the jasmine branch Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.