Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to filter table of countries #72

Merged
merged 3 commits into from Sep 5, 2014
Merged

Allow users to filter table of countries #72

merged 3 commits into from Sep 5, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 1, 2014

screen shot 2014-09-01 at 11 46 55

fofr added 3 commits Aug 29, 2014
Travel Advice Publisher is known to have a larger portion of IE7 users.
IE7 doesn’t handle the dynamic rendering of tables so well, so hide
this feature from these users.
@dhwthompson
Copy link
Contributor

@dhwthompson dhwthompson commented Sep 4, 2014

This feels to me like it’s mixing a lot of layers together.

The functionality to filter the country list is JavaScript; it’s an additional perk for those who have the JavaScript to support it (which excludes, for example, those on IE 6 or 7; that’s fine).

However, the form to trigger this filtering is implemented in the base HTML, then hidden away by the CSS on top of that, then redisplayed in some way when the JavaScript loads. Wouldn’t it make more sense, if JavaScript is adding the filtering functionality, to have JavaScript add in the filtering form?

@fofr
Copy link
Contributor Author

@fofr fofr commented Sep 4, 2014

As this is a pattern that originates from and is recommended by govuk_admin_template, and is already being used in other apps, can I suggest we continue the discussion as an issue here: https://github.com/alphagov/govuk_admin_template/issues

@dhwthompson
Copy link
Contributor

@dhwthompson dhwthompson commented Sep 4, 2014

Yup; that’s fair.

vinayvinay added a commit that referenced this pull request Sep 5, 2014
Allow users to filter table of countries
@vinayvinay vinayvinay merged commit d1935eb into master Sep 5, 2014
1 check passed
1 check passed
default "Build #24 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the country-filter branch Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.