Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve legibility of diff views #78

Merged
merged 3 commits into from Dec 24, 2014
Merged

Improve legibility of diff views #78

merged 3 commits into from Dec 24, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 23, 2014

New lines were displaying as thin strips. Spaces between lines made making comparisons more difficult. The +/- signs were hard to read against grey text.

  • Give each line in the diff a minimum height, making new lines display thicker and maintaining a vertical rhythm
  • Remove space between lines, the content naturally provides this spacing
  • Extend red/green highlight to edges of the view
  • Use darker red and green colours for the +/- icons

Based on alphagov/publisher#335

Before

screen shot 2014-12-23 at 15 02 26

After

screen shot 2014-12-23 at 15 02 42

fofr added 3 commits Dec 23, 2014
* Fix alignment of environment label
New lines were displaying as thin strips. Spaces between lines made
making comparisons more difficult. The +/- signs were hard to read
against grey text.

* Give each line in the diff a minimum height, making new lines display
thicker and maintaining a vertical rhythm
* Remove space between lines, the content naturally provides this
spacing
* Extend red/green highlight to edges of the view
* Use darker red and green colours for the +/- icons

Based on alphagov/publisher#335
steventux added a commit that referenced this pull request Dec 24, 2014
Improve legibility of diff views
@steventux steventux merged commit be17663 into master Dec 24, 2014
1 check passed
1 check passed
default "Build #41 succeeded on Jenkins"
Details
@steventux steventux deleted the diff-legibility branch Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.