Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop nesting filter search results when dynamically loading #1630

Merged
merged 2 commits into from Jul 30, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 28, 2014

  • The JavaScript takes the HTML response and embeds it within the container with a search_results ID. This leads to nested span9 elements appearing within the page and duplicate elements with the same ID. This had the effect of showing a thinner results table when filtering in-page.
  • Use number_with_delimiter for readable numbers
  • Put the number and text into a left-to-right readable form, ie “3,956 documents” reads better than “Documents 3956”

(I suggest adding &w=1 to the Github URL when reviewing code changes)

Before:
screen shot 2014-07-28 at 15 18 20

After:
screen shot 2014-07-28 at 15 17 36

fofr added 2 commits Jul 25, 2014
* The JavaScript takes the HTML response and embeds it within the
container with a search_results ID. This leads to nested span9 elements
appearing within the page and duplicate elements with the same ID.
* This had the effect of showing a thinner results table when filtering
in-page.
* Use number_with_delimiter for readable numbers
* Put the number and text into a left-to-right readable form, ie “3,956
documents” reads better than “Documents 3956”
@vinayvinay
Copy link
Contributor

@vinayvinay vinayvinay commented Jul 29, 2014

👍 feel free to merge when approved.

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 30, 2014

@marksheldonGDS is happy with this.

fofr added a commit that referenced this pull request Jul 30, 2014
Stop nesting filter search results when dynamically loading
@fofr fofr merged commit a384b37 into master Jul 30, 2014
1 check passed
1 check passed
default Build #3612 succeeded on Jenkins
Details
@fofr fofr deleted the inline-filter-fix branch Jul 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.