Improve role date selection

[fofr]

• Starting from 1700 and having to scroll all the way down to 2014, or even 2019, is painful
• Restrict date entries to current year rather than current year + 5 which seemed to be the default
• Refine copy about why roles cannot be changed later

[fofr]

Before:

After:

[wryobservations]

Hurray!

…

Lisa Scott Associate Product Manager, GOV.UK Government Digital Service, Aviation House, 125 Kingsway, London WC2B 6NH ***@***.*** Product updates for GOV.UK: https://insidegovuk.blog.gov.uk/ GDS blog: http://digital.cabinetoffice.gov.uk/ Please use the support form! https://www.gov.uk/support/internal On 13 Aug 2014, at 10:25, Paul Hayes ***@***.*** wrote: Before: After: — Reply to this email directly or view it on GitHub.

[wryobservations]

Looks good to me.

Lisa Scott
Associate Product Manager, GOV.UK
Government Digital Service, Aviation House, 125 Kingsway, London WC2B 6NH

lisa.scott@digital.cabinet-office.gov.uk

Product updates for GOV.UK: https://insidegovuk.blog.gov.uk/
GDS blog: http://digital.cabinetoffice.gov.uk/

Please use the support form! https://www.gov.uk/support/internal

On 13 Aug 2014, at 13:37, Paul Hayes notifications@github.com wrote:

Starting from 1700 and having to scroll all the way down to 2014, or even 2019, is painful
Restrict date entries to current year rather than current year + 5 which seemed to be the default
Refine copy about why roles cannot be changed later
You can merge this Pull Request by running

git pull https://github.com/alphagov/whitehall improve-role-date-selection
Or view, comment on, or merge it at:

#1658

Commit Summary

Start role year selects at this year, not 1700
Refine role copy
File Changes

M app/views/admin/role_appointments/_form.html.erb (6)
Patch Links:

https://github.com/alphagov/whitehall/pull/1658.patch
https://github.com/alphagov/whitehall/pull/1658.diff
—
Reply to this email directly or view it on GitHub.

[dhwthompson]

I’m not sure this sentence still holds together with just a comma. I’m no content designer, but could I suggest using a semicolon instead?

[alext]

Or even just 2 sentences?

[tekin]

Agreed. Full stop instead of comma.

[fofr]

I agree. Two sentences. Rebased.

[tekin]

Code looks good 👍. Merge away once PO-accepted.