Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak styles of document list filters and results #1674

Merged
merged 13 commits into from Aug 20, 2014
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 20, 2014

  • Code review
  • Product review

  • Use smart quotes in titles
  • Update placeholder copy to match content style guide
  • Use a Bootstrap button for filter form
  • Pluralise document counts correctly
  • Make more use of ported admin template styles for no content states and table headers

Before

screen shot 2014-08-20 at 11 21 52
screen shot 2014-08-20 at 11 22 26

After

screen shot 2014-08-20 at 11 15 49

screen shot 2014-08-20 at 11 16 09

screen shot 2014-08-20 at 11 19 34

fofr added 13 commits Aug 19, 2014
* Also cleanup margins on filter heading
* Make the action more prominent and consistent with the rest of the
application, also separates it a bit from the reset link below
* eg 1 published document, 2 published documents
* Remove `strong` tags from around numbers
* Match document list filters by using the same sized grid elements
* Remove custom span2 styling
* Use table-header styles brought across from govuk_admin_template
* Make feature filter and document filter table styles match
* Use the no content styles brought across from govuk_admin_template
* Match other form elements within app
* For clarity
* Separate from content above using thematic break
* Give a bit of extra vertical spacing
@dhwthompson
Copy link
Contributor

@dhwthompson dhwthompson commented Aug 20, 2014

Use smart quotes in titles

😀

@bishboria
Copy link
Contributor

@bishboria bishboria commented Aug 20, 2014

👍

fofr added a commit that referenced this pull request Aug 20, 2014
Tweak styles of document list filters and results
@fofr fofr merged commit 061830f into master Aug 20, 2014
1 check passed
1 check passed
default Build #3902 succeeded on Jenkins
Details
@fofr fofr deleted the document-list-tweaks branch Aug 20, 2014
@wryobservations
Copy link

@wryobservations wryobservations commented Aug 20, 2014

Looks good.

Lisa Scott
Associate Product Manager, GOV.UK
Government Digital Service, Aviation House, 125 Kingsway, London WC2B 6NH

lisa.scott@digital.cabinet-office.gov.uk

Product updates for GOV.UK: https://insidegovuk.blog.gov.uk/
GDS blog: http://digital.cabinetoffice.gov.uk/

Please use the support form! https://www.gov.uk/support/internal

On 20 Aug 2014, at 15:02, Paul Hayes notifications@github.com wrote:

Merged #1674.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.