Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metadata link tracking #1982

Merged
merged 1 commit into from Feb 20, 2015
Merged

Remove metadata link tracking #1982

merged 1 commit into from Feb 20, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 19, 2015

As part of moving analytics from classic to universal, we’ve audited the custom variables being set and whether they are still being used. Ash identified this variable as being unused and marked it for deletion. It will not be switched over to Universal.

Undoes 7583621

Before merging

  • Search and browse confirm this isn't useful
As part of moving analytics from classic to universal, we’ve audited
the custom variables being set and whether they are still being used.

Ash identified this variable as being unused and marked it for
deletion. It will not be switched over to Universal.

Undoes 7583621
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Feb 19, 2015

Search and browse confirm this isn't useful

Do you mean Finding Things? I don't think Search and Browse exist any longer.

@rboulton
Copy link
Contributor

@rboulton rboulton commented Feb 19, 2015

I think you need to talk to @edds who did the work on this.

@edds
Copy link
Contributor

@edds edds commented Feb 19, 2015

I am fine with it. Does the finding things team still want to know which metadata is clicked? It was added to help us think about finding content from whitehall documents.

@rboulton
Copy link
Contributor

@rboulton rboulton commented Feb 19, 2015

I think that this might well be of interest. However, we really need to get this sort of information for much more than just metadata links - clicks on footers, vs related links, etc.

In the current form, this tracking is probably more annoyingly sparse than useful, so I'm all for removing this for now to tidy up the code and free up a custom variable. We can resurrect this idea for tracking the stuff we actually care about, in future.

@edds
Copy link
Contributor

@edds edds commented Feb 20, 2015

👍 This looks good to merge to me.

fofr added a commit that referenced this pull request Feb 20, 2015
Remove metadata link tracking
@fofr fofr merged commit 0d6a589 into master Feb 20, 2015
1 check passed
1 check passed
default Build #5176 succeeded on Jenkins
Details
@fofr fofr deleted the remove-metadata-link-tracking branch Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.