Track social media shares in Universal #1998
Merged
Conversation
Update to using `trackShare` method on GOVUK.analytics. This sends the social event to both classic and universal. * Simplify tests to the minimum HTML fixture necessary
|
Is it worth adding a |
|
If The error might be tracked, which might be useful in tracking down a larger issue. If the tracking is failing and users aren't affected, I'd rather not mask the error. |
|
They are great points. As long as the user can still do what they need to do |
fofr
changed the title
fofr
added a commit
that referenced
this pull request
Mar 2, 2015
Track social media shares in Universal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Update to using
GOVUK.analytics.trackSharemethod instead of using the Google Analytics API directly. This will send the social media event to both classic and universal.See also:
alphagov/static#550
https://www.pivotaltracker.com/story/show/88174796
cc @benilovj