Derive Government from Edition at run-time, rather than persisting on Document #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Government was set based on `first_published_at`, which does not work for consultations and speeches; - Consultations do not set a `first_published_at` - Speeches have a `delivered_on`, which may be different from `first_published_at`, and is usually earlier. Add a new method to expose the right date to identify a Government responsible for the Edition.
This association is not used anywhere in the app. Getting rid of it as a pre step to refactoring the derivation of government on editions.
We've moving away from Government being set on Document, and instead being derived from the Edition itself. Move the "which government owns this edition" logic into the Edition model itself. Update the publishing workflow to use this, rather than having to know about Edition/Government relationships.
We now derive Government from an Edition, on demand, rather than pre-calculating it and storing it on Document.
- Break date related tests into their own class - Use new government factories - Generally much easier to read and understand intent 👍
Don't use :scope when returning a single value, use class methods instead. Remove redundant nil (implicit from return) and make the guard vs lookup more distinct
Contributor
|
👍 Good changes. |
dsingleton
added a commit
that referenced
this pull request
Mar 4, 2015
Derive Government from Edition at run-time, rather than persisting on Document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking this approach simplifies the code significantly, keeping the relationship to
Governmentencapsulated inEdition, and there's not a need to de-normalise ontoDocumentyet, and if becomes needed it can be added and backfilled then.Changes:
Speech, using thedelivered_onin preference tofirst_published_at, as there are many examples wheredelivered_onis much earlier.Edition#government, and derived at run-time, rather than being set during publishing.Document.governmentfield - which isn't used anywhere yet.Governments and refactors the tests to be more readable.This supports:
Governmentis derived atPaired with @tekin