Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slimmer and remove `proposition` slimmer header #2030

Merged
merged 2 commits into from Mar 18, 2015
Merged

Update slimmer and remove `proposition` slimmer header #2030

merged 2 commits into from Mar 18, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 16, 2015

  • Update Slimmer to 8.1.0 to stop using Javascript variables and start using <meta> tags, for our analytics to set custom dimensions in Google Analytics.
  • Remove the now unused proposition header and corresponding tests

Relevant slimmer PRs:
alphagov/slimmer#119
alphagov/slimmer#114

Changelog:
https://github.com/alphagov/slimmer/blob/master/CHANGELOG.md

fofr added 2 commits Mar 16, 2015
* Pull in slimmer analytics updates
Slimmer no longer uses this header. It was previously being used to
configure a proposition custom variable for classic Google Analytics.
@edds
Copy link
Contributor

@edds edds commented Mar 16, 2015

LGTM

fofr added a commit that referenced this pull request Mar 18, 2015
Update slimmer and remove `proposition` slimmer header
@fofr fofr merged commit 27dd792 into master Mar 18, 2015
1 check passed
1 check passed
default Build #5388 succeeded on Jenkins
Details
@fofr fofr deleted the bump-slimmer branch Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.