Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transition progress indicators from organisation list #2105

Merged
merged 7 commits into from Apr 21, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 21, 2015

With transition over and any further transitions not being part of the transition program the progress bars are no longer needed.

https://www.pivotaltracker.com/story/show/92901996

  • Remove transition visualisation logic, templates and styles
  • Remove unused 'X live on GOV.UK' copy
  • Remove all uses of Whitehall::organisations_transition_visualisation_feature_enabled

Essentially undoes:
#1001
#1023
#1374

Before

screen shot 2015-04-21 at 15 28 36

After

screen shot 2015-04-21 at 15 28 51

fofr added 7 commits Apr 21, 2015
With transition over and any further transitions not being part of the
transition program the progress bars no longer serve a purpose.
These were only used in the transition progress partial, and can now be
removed.
Alongside organisations it states “separate website” or “moving to
GOV.UK”, this was conditional based on whether the visualisation was
enabled.

The visualisation is being removed, but these messages are still useful
and should remain. Always show them.

Remove all uses of `show_transition_state`
Beneath the organisation count a message used to display how many orgs
were live on GOV.UK. These messages were disabled when the transition
progress bar was added.

We no longer need to display the progress of transition, remove these
messages.

* Remove `show_govuk_status` partial variable
* Remove uses of
`organisations_transition_visualisation_feature_enabled` flag
Remove flag, but leave accessor in place until alphagov-deployment has
been updated.
@evilstreak
Copy link
Contributor

@evilstreak evilstreak commented Apr 21, 2015

👍

fofr added a commit that referenced this pull request Apr 21, 2015
Remove transition progress indicators from organisation list
@fofr fofr merged commit 0daa6a2 into master Apr 21, 2015
1 check passed
1 check passed
default Build #5707 succeeded on Jenkins
Details
@fofr fofr deleted the remove-org-progress-bars branch Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.