Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent statistics tabs from causing horizontal scroll #2193

Merged
merged 1 commit into from May 21, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 21, 2015

Using 100% width with padding will cause an element to grow larger than its container. At smaller browser widths this causes horizontal scrolling.

  • Use border-box so the padding is taken into account when calculating the full width.

Fixes https://www.pivotaltracker.com/story/show/94287040

Problem

screen shot 2015-05-21 at 16 23 31

Before

screen shot 2015-05-21 at 16 24 14

After

screen shot 2015-05-21 at 16 24 25

Using 100% width with padding will cause an element to grow larger than
its container.

At smaller browser widths this causes horizontal scrolling.

Use border-box so the padding is taken into account when calculating
the full width.
@edds
Copy link
Contributor

@edds edds commented May 21, 2015

👍

fofr added a commit that referenced this pull request May 21, 2015
Prevent statistics tabs from causing horizontal scroll
@fofr fofr merged commit 1001b98 into master May 21, 2015
1 check passed
1 check passed
@govuk-ci
default Build #6119 succeeded on Jenkins
Details
@fofr fofr deleted the stats-tabs-width branch May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants