Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sideways scrolling on service priority organisation pages #2194

Merged
merged 1 commit into from May 26, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 22, 2015

Fixes https://www.pivotaltracker.com/story/show/92350934
Zendesk: https://govuk.zendesk.com/tickets/974685

The .service-priority class was including grid-row styles to contain floats, but this came with a negative margin. This negative margin caused sideways scrolling on thin page widths. Instead use the existing floated-children class on the inner block to contain the floats (and alter padding at different screen sizes) and stop extending with grid-row.

Outcome is a page that looks exactly the same but doesn’t sideways scroll.

Example of live bug: https://www.gov.uk/government/organisations/driver-and-vehicle-standards-agency

image1

The `.service-priority` class was including grid-row styles to contain
floats, but this came with a large negative margin. This negative
margin caused sideways scrolling on thin page widths.

Instead use the existing `floated-children` class on the inner block to
contain the floats (and alter padding at different screen sizes) and
stop extending with `grid-row`.

Outcome is a page that looks exactly the same but doesn’t sideways
scroll.
@edds
Copy link
Contributor

@edds edds commented May 26, 2015

👍

fofr added a commit that referenced this pull request May 26, 2015
Fix sideways scrolling on service priority organisation pages
@fofr fofr merged commit c929471 into master May 26, 2015
1 check passed
1 check passed
default Build #6121 succeeded on Jenkins
Details
@fofr fofr deleted the fix-sideways-scrolling-org-pages branch May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.