Fix sideways scrolling on service priority organisation pages #2194
Conversation
The `.service-priority` class was including grid-row styles to contain floats, but this came with a large negative margin. This negative margin caused sideways scrolling on thin page widths. Instead use the existing `floated-children` class on the inner block to contain the floats (and alter padding at different screen sizes) and stop extending with `grid-row`. Outcome is a page that looks exactly the same but doesn’t sideways scroll.
|
|
fofr
added a commit
that referenced
this pull request
May 26, 2015
Fix sideways scrolling on service priority organisation pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes https://www.pivotaltracker.com/story/show/92350934
Zendesk: https://govuk.zendesk.com/tickets/974685
The
.service-priorityclass was including grid-row styles to contain floats, but this came with a negative margin. This negative margin caused sideways scrolling on thin page widths. Instead use the existingfloated-childrenclass on the inner block to contain the floats (and alter padding at different screen sizes) and stop extending withgrid-row.Outcome is a page that looks exactly the same but doesn’t sideways scroll.
Example of live bug: https://www.gov.uk/government/organisations/driver-and-vehicle-standards-agency