Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart quotes ’n’ ellipses… #2257

Merged
merged 3 commits into from Jul 6, 2015
Merged

Smart quotes ’n’ ellipses… #2257

merged 3 commits into from Jul 6, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 6, 2015

Minor typography improvements to Whitehall.

fofr added 3 commits Jul 6, 2015
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jul 6, 2015

Do these work OK in IE? I have a vague recollection of having to globally find and replace ’ with ’ in a previous lifetime.

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 6, 2015

@boffbowsh Checked in IE6, IE7, IE8 and they work fine.

@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jul 6, 2015

👍

fofr added a commit that referenced this pull request Jul 6, 2015
Smart quotes ’n’ ellipses…
@fofr fofr merged commit 2321f77 into master Jul 6, 2015
1 check passed
1 check passed
default Build #6471 succeeded on Jenkins
Details
@fofr fofr deleted the ellipses-and-smart-quotes branch Jul 6, 2015
@issyl0
Copy link
Contributor

@issyl0 issyl0 commented Jul 6, 2015

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.