Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump admin gem for IE7 fixes #2264

Merged
merged 3 commits into from Jul 9, 2015
Merged

Bump admin gem for IE7 fixes #2264

merged 3 commits into from Jul 9, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 9, 2015

Version 2.3.4 uses a fixed width grid in IE7 so that editing editions, viewing editions and finding editions is easier in Whitehall. It is still far from perfect but is significantly more usable for those users stuck on IE7.

The most notable remaining problem is modals which fail to display correctly. For this reason the force publish modal has been disabled (the button links through to a form on IE7)

screen shot 2015-07-09 at 11 20 29

fofr added 2 commits Jul 9, 2015
* Version 2.3.4 uses an IE7 compatible fixed width grid so that
editing, viewing content and finding content is easier in Whitehall.
* Modals will continue to not work correctly
For the new IE7 grid to work columns need to be correctly wrapped in a
`row` container.
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jul 9, 2015

👍

Disable linked modals on IE7, as modals don’t work well.
@boffbowsh
Copy link
Contributor

@boffbowsh boffbowsh commented Jul 9, 2015

👍 for the modal change

fofr added a commit that referenced this pull request Jul 9, 2015
Bump admin gem for IE7 fixes
@fofr fofr merged commit a6cbc42 into master Jul 9, 2015
1 check was pending
1 check was pending
default Build #6502 is running on Jenkins
Details
@fofr fofr deleted the ie7-bs3-fixes branch Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.