Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contextual nav styles for older browsers #2415

Merged
merged 2 commits into from Dec 18, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 17, 2015

Addresses https://govuk.zendesk.com/agent/tickets/1208617

We’re using a media min-width hack to apply some styles to browsers that support media queries. These style use pseudo elements to create a list item with a dash.

In older browsers, IE8 and below, users were seeing a numbered list, which would render poorly when numbers got into double digits.

  • Use a disc style rather than numbers to match intention of modern browser styles
  • Make the list position outside (the default), move the margin clause outside of the media query as it now applies to both, and simplify the list-style reset to only affect the type not the position.

Modern browsers

screen shot 2015-12-17 at 12 43 07

## Before (IE8)

screen shot 2015-12-17 at 12 33 11

## After (IE8)

screen shot 2015-12-17 at 12 32 47

## Before (IE7)

screen shot 2015-12-17 at 12 41 11

## After (IE7)

screen shot 2015-12-17 at 12 41 33

fofr added 2 commits Dec 17, 2015
We’re using a media min-width hack to apply some styles to browsers
that support media queries. These style use pseudo elements to create a
list item with a dash.

In older browsers, IE8 and below, users were seeing a numbered list,
which would render poorly when numbers got into double digits.

* Use a `disc` style rather than numbers to match intention of modern
browser styles
* Make the list position outside (the default), move the margin clause
outside of the media query as it now applies to both, and simplify the
list-style reset to only affect the type not the position.
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Dec 18, 2015

LGTM.

fofr added a commit that referenced this pull request Dec 18, 2015
Improve contextual nav styles for older browsers
@fofr fofr merged commit 46a6999 into master Dec 18, 2015
1 check passed
1 check passed
default Build #7034 succeeded on Jenkins
Details
@fofr fofr deleted the improve-contextual-nav-ie branch Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.