Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete take part’s frontend parts #2441

Merged
merged 3 commits into from Jan 27, 2016
Merged

Delete take part’s frontend parts #2441

merged 3 commits into from Jan 27, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 25, 2016

Deletes:

  • styles
  • template
  • controller
  • test assertions for rendered show pages

While the controller isn’t needed as Whitehall is no longer serving these routes, the route itself needs to be kept. We rely on the routes defined in config/routes.rb to generate methods which give us the public URLs for those things. If we want to remove the routes, which we should, then we need to create substitutes for those methods ourselves.

A separate story to address this: https://trello.com/c/wvdvAKek/

For now the route has been left in, with a comment. @jamiecobbett and I considered the work to resolve this too large, and shouldn't block this clean-up PR. It will affect any format being migrated where we wish to remove old frontend code in Whitehall.

https://trello.com/c/TLCjyX9x/269-take-part-remove-any-frontend-code-in-whitehall

cc @dsingleton @boffbowsh @gpeng @benlovell

fofr added 2 commits Jan 25, 2016
While the controller isn’t needed as Whitehall frontend is no longer
serving these routes, the `route` needs to be kept so that rails path
and url helpers are available, these are used in the Get Involved view,
and to generate the `search_link`.

Story to address this here:
https://trello.com/c/wvdvAKek/

Also removes assertions that the Take Part pages render correctly.
Background:
Given I am a GDS editor

This comment has been minimized.

@benlovell

benlovell Jan 26, 2016
Contributor

@benilovj
Copy link
Contributor

@benilovj benilovj commented Jan 26, 2016

As mentioned in person, it may be good to move app/views/take_part_pages/_take_part_page.html.erb to app/views/home/ so it's closer to get_involved.html.erb, which is the only place where it's used.

When the time comes to remove the get involved page, the referenced
partial in `take_part_pages` could be missed.

* Move into a single template
@fofr
Copy link
Contributor Author

@fofr fofr commented Jan 26, 2016

@benilovj Done in 542a2c7

@benilovj
Copy link
Contributor

@benilovj benilovj commented Jan 26, 2016

👍

fofr added a commit that referenced this pull request Jan 27, 2016
Delete take part’s frontend parts
@fofr fofr merged commit ec3932e into master Jan 27, 2016
1 check passed
1 check passed
default Build #7275 succeeded on Jenkins
Details
@fofr fofr deleted the delete-take-part branch Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.